Commit e148647
committed
Add a direct test of run_commit_hook
This has three benefits:
- run_commit_hook is public, being listed in git.index.fun.__all__,
so it makes sense for it to have its own test.
- When investigating (future, or current xfail-covered) failure of
functions that use run_commit_hook, it will be useful to compare
the results of other tests that already do exist to that of a
direct test of run_commit_hook.
- When changing which bash.exe run_commit_hook selects to use on
Windows (including to ameliorate the limitation covered by the
WinBashStatus.WslNoDistro xfail marks, or to attempt other
possible changes suggested in gitpython-developers#1745), or even just to investigate
the possibility of doing so, it will make sense to add tests like
this test but for more specific conditions or edge cases. Having
this typical-case test to compare to should be helpful both for
writing such tests and for efficiently verifying that the
conditions they test are really the triggers for any failures.1 parent f664a0b commit e148647
1 file changed
+19
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
991 | 991 | | |
992 | 992 | | |
993 | 993 | | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
994 | 1012 | | |
995 | 1013 | | |
996 | 1014 | | |
| |||
0 commit comments