Reduce ping latency #8344
Open
Reduce ping latency #8344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <[email protected]>
One reason why ping processing could be slow is that, once we receive a message from the peer to send to a subdaemon, we don't listen for others until we've drained that subdaemon queue entirely. This actually happens, though, for reestablish: we really can take more than a second to set that subdaemon up. Signed-off-by: Rusty Russell <[email protected]>
…sage. If we do this, we can cause delays in non-channel messages (like gossip, and pings). On a busy system, a WIRE_REESTABLISH message can easily take a second to resolve, as a new subdaemon has to be spun up and connected before we can drain the queue). It also should be slightly more efficient in processing common packet patterns (ADD then COMMITMENT_SIGNED, etc). Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: We will now process incoming non-channel messages (gossip, pings) in a more timely manner.
rustyrussell
force-pushed
the
guilt/debug-ping
branch
from
40d111b to
1640fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch was to help me test pings across the network. But the real fix is the final one: we now process more messages before ignoring peer while we wait for them to be queued to other subdaemons.
See-also: #7742
See-also: #8308