Skip to content

askrene: add runtime of getroutes to the logs #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lagrang3
Copy link
Collaborator

@Lagrang3 Lagrang3 commented Dec 11, 2024

Add log information about the runtime of getroutes in the form

get_routes completed in X ms

Is this proper naming?
The string should have a unique signature to be able to extract it with regex patterns.

@Lagrang3
Copy link
Collaborator Author

Putting this into draft. As I am thinking we could do more than runtime statistics and even broadcast these values
in a "message" to listening plugins.

@Lagrang3 Lagrang3 marked this pull request as draft December 12, 2024 20:35
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 9246744 to 1e27620 Compare March 12, 2025 09:04
@Lagrang3 Lagrang3 marked this pull request as ready for review March 12, 2025 09:04
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 1e27620 to 7e173e2 Compare March 12, 2025 11:15
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 7e173e2 to 4a840c2 Compare March 24, 2025 07:02
@Lagrang3 Lagrang3 requested a review from rustyrussell March 25, 2025 11:03
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 4a840c2 to 2314e1c Compare April 30, 2025 10:44
Add log information about the runtime of getroutes.

Changelog-None: askrene: add runtime of getroutes to the logs

Signed-off-by: Lagrang3 <[email protected]>
@Lagrang3 Lagrang3 force-pushed the askrene-measure-time branch from 2314e1c to e32f2ca Compare May 19, 2025 05:21
@Lagrang3 Lagrang3 added this to the v25.08 milestone May 19, 2025
@Lagrang3 Lagrang3 mentioned this pull request May 19, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants