dns: only allow one DNS announcement #4996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 6df2e9c |
|
@cdecker @TheBlueMatt and others mentioning that the network should really limit on gossip content, but currently nobody enforces anything so the limits were removed from the spec. So as a first step we can add a rule that at least our implementation can't be used to spam gossip by commandline. |
|
Also, currenlty RFC #911 does forsee to ignore and drop node_updates that contain more than one DNS name. |
|
Update: Rust-Lightning seems picking up on this :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since upcoming lightning/bolts#911 will likely contain
- MUST NOT announce more than one "type 5" DNS hostname.we need to add this.Changelog-None