Let channeld add the outgoing channel as soon as funding locked on both sides #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on top of master now that #413 is merged. |
rustyrussell
previously requested changes
Dec 18, 2017
gossipd/gossip.c
Outdated
|
|
||
| /* Sent from channeld through its gossip_fd */ | ||
| case WIRE_GOSSIP_LOCAL_ADD_CHANNEL: | ||
| break; | ||
| } |
There was a problem hiding this comment.
This is deeply confusing.
Just remove gossip_local_add_channel and the weird call to it: the "break;" here does exactly what we want if the master sends us that message for some reason.
There was a problem hiding this comment.
See also line 1601, and the weird function it calls, which AFAICT shouldn't exist?
There was a problem hiding this comment.
Oh wow, seems I botched up a rebase somewhere, sorry about that
|
Great, thanks for the review @rustyrussell, I added a fixup and I'll squash and merge if you're ok with it |
cdecker
dismissed
rustyrussell’s stale review
Removed the scaffolding I completely forgot about :-)
Couldn't find a good place to put these messages, we probably want to do the same capability based request routing that we did for the HSM, but for now this just defines the message in the master messages file. Signed-off-by: Christian Decker <[email protected]>
Signed-off-by: Christian Decker <[email protected]>
This adds the channel from us to the remote node and activates it with our local parameters. Signed-off-by: Christian Decker <[email protected]>
Relatively simple: until we reach funding-depth the channels should be known locally, so we can already route through them, but they should not be announced to peers to which the connection is non-local. Signed-off-by: Christian Decker <[email protected]>
rustyrussell
force-pushed
the
pr414-take2
branch
from
094fc88 to
89e2b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #414. The main difference is that instead of having unsigned
channel_announcementandchannel_updatemessages that are allowed through if they are local, we add a new message thatchanneldcan send togossipdwhen both sides lock. This message now contains only the necessary information for the outgoing direction, and will immediately activate the channel so we can use it.Fixes #284
Depends on #413 (only the last 4 commits are for this PR, all others are from #413)