Skip to content

make default target not include the target to generate code from the schema #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddustin opened this issue Jun 27, 2023 · 4 comments
Closed

make default target not include the target to generate code from the schema #6365

ddustin opened this issue Jun 27, 2023 · 4 comments
Assignees
@vincenzopalazzo
Labels
bug build

Comments

@ddustin
Copy link
Collaborator

ddustin commented Jun 27, 2023 •
edited
Loading

When changing the RPC, the documentation auto generate doesn't seem to trigger. Doing these commands seems to generate the RPC documentation manually.

PYTHONPATH=contrib/msggen python3 contrib/msggen/msggen/__main__.py

python -m grpc_tools.protoc -I cln-grpc/proto cln-grpc/proto/node.proto --python_out=contrib/pyln-testing/pyln/testing/ --grpc_python_out=contrib/pyln-testing/pyln/testing/ --experimental_allow_proto3_optional
python -m grpc_tools.protoc -I cln-grpc/proto cln-grpc/proto/primitives.proto --python_out=contrib/pyln-testing/pyln/testing/ --experimental_allow_proto3_optional

find contrib/pyln-testing/pyln/testing/ -type f -name "*.py" -print0 | xargs -0 sed -i  's/^import \(.*\)_pb2 as .*__pb2/from . import \1_pb2 as \1__pb2/g'

These commands are ripped from the toplevel Makefile. Something seems to be making these not fire automatically during make.
@vincenzopalazzo
Copy link
Collaborator

Mh, for what rpc are you changing the docs? Some of the RPC are not mapped to the GRPC code gen

@ddustin
Copy link
Collaborator Author

ddustin commented Jun 28, 2023

Instagibbs & I both ran into the same issue. You can see it happen on my PR #6253 and his #6035

@instagibbs
Copy link
Contributor

unsure if it's why, but I'm still having issues on my taproot PR I can't really diagnose

@vincenzopalazzo vincenzopalazzo changed the title RPC Autogen make default target not include the target to generate code from the schema Jun 30, 2023
@vincenzopalazzo vincenzopalazzo self-assigned this Jun 30, 2023
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Jun 30, 2023
@vincenzopalazzo
build: Regenerate the generated file as the default target
e98f5c1 
When modifying the schema, regenerating the file can be challenging.
This change sets the autogenerate file as the default target, m
aking the process more convenient and simplifying our workflow.

Fixes ElementsProject#6365
Report-by: Dusty Daemon
Changelog-None
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo mentioned this issue Jun 30, 2023
Closed
@vincenzopalazzo
Copy link
Collaborator

Ok, someone can test this #6372 ?

instagibbs pushed a commit to instagibbs/lightning that referenced this issue Jun 30, 2023
@vincenzopalazzo @instagibbs
build: Regenerate the generated file as the default target
25ee6e0 
When modifying the schema, regenerating the file can be challenging.
This change sets the autogenerate file as the default target, m
aking the process more convenient and simplifying our workflow.

Fixes ElementsProject#6365
Report-by: Dusty Daemon
Changelog-None
Signed-off-by: Vincenzo Palazzo <[email protected]>
rustyrussell pushed a commit to instagibbs/lightning that referenced this issue Jul 10, 2023
@vincenzopalazzo @rustyrussell
build: Regenerate the generated file as the default target
3d97754 
When modifying the schema, regenerating the file can be challenging.
This change sets the autogenerate file as the default target, m
aking the process more convenient and simplifying our workflow.

Fixes ElementsProject#6365
Report-by: Dusty Daemon
Changelog-None
Signed-off-by: Vincenzo Palazzo <[email protected]>
rustyrussell pushed a commit to instagibbs/lightning that referenced this issue Jul 10, 2023
@vincenzopalazzo @rustyrussell
build: Regenerate the generated file as the default target
2c1d579 
When modifying the schema, regenerating the file can be challenging.
This change sets the autogenerate file as the default target, m
aking the process more convenient and simplifying our workflow.

Fixes ElementsProject#6365
Report-by: Dusty Daemon
Changelog-None
Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
bug build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Regenerate the generated file as the default target vincenzopalazzo/lightning
3 participants
@ddustin @instagibbs @vincenzopalazzo