Skip to content

Dual funding gets upset if peer has funding tx mined before we sendrawtransaction #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rustyrussell opened this issue May 31, 2022 · 0 comments
Closed

Dual funding gets upset if peer has funding tx mined before we sendrawtransaction #5296

rustyrussell opened this issue May 31, 2022 · 0 comments
Assignees
@niftynei
Labels
dualfunding

Comments

@rustyrussell
Copy link
Contributor

Fails lnprototest every so often:

See: rustyrussell/lnprototest#53

pyln.client.lightning.RpcError: RPC call failed: method: fundchannel, payload: {'id': '02c6047f9441ed7d6d3045406e95c07cd85c778e4b8cef3ca7abac09b95c709ee5', 'amount': 999877, 'feerate': '253perkw', 'announce': True}, error: {'code': 303, 'message': 'Error broadcasting funding tx: error code: -27\\\\nerror message:\\\\nTransaction already in block chain. Unsent tx discarded 020000000001022f144a38afb7c3886d18f5283a8da92e79c7f6a24a64a5c7f9d5187ac2753f360500000000fdffffff2f144a38afb7c3886d18f5283a8da92e79c7f6a24a64a5c7f9d5187ac2753f360300000000fdffffff036e8501000000000016001473daa75958d5b2ddca87a6c279bb7cb307167037455c150000000000220020c46bf3d1686d6dbb2d9244f8f67b90370c5aa2747045f1aeccb77d818711738261841e0000000000160014d640ab16f347d1de5aba5a715321a5fc4ba9a5d502473044022009d5bfb9787760ca0c75ee751d5144556f56fcd271267bc08909a961986caa7602207d5110cebf5319ca112436d6b1f2966c3f363ff3c0bc3a1081d425ca25a4cb32012102c6047f9441ed7d6d3045406e95c07cd85c778e4b8cef3ca7abac09b95c709ee502473044022005b993028da10ee8a7e87e9075db0bcb45102096edcbc667a83e4dd54070d10402207eac5f16eea9fc0e61072e4ca67f05144cece92190a9560f85e1ccbd8f2c3958012102ffef0c295cf7ca3a4ceb8208534e61edf44c606e7990287f389f1ea055a1231c66000000.', 'data': {'id': '02c6047f9441ed7d6d3045406e95c07cd85c778e4b8cef3ca7abac09b95c709ee5', 'method': 'openchannel_signed'}}
=========================== short test summary info ============================
FAILED tests/test_bolt2-20-open_channel_accepter.py::test_open_opener_with_inputs
@rustyrussell rustyrussell mentioned this issue May 31, 2022
Merged
niftynei added a commit to niftynei/lightning that referenced this issue Jul 1, 2022
@niftynei
df: check mempool/block for funding output on broadcast fail
9bdae78 
If we can't broadcast the tx, confirm that it didn't end up in the
mempool or the utxo set before throwing an error.

Note that this doesn't protect us in the case where the funding
output has already been *spent*... but that's extremely rare, right?

Fixes ElementsProject#5296

Reported-By: @rustyrussell
Collab-With: @vincenzopalazzo
@niftynei niftynei mentioned this issue Jul 1, 2022
Closed
vincenzopalazzo pushed a commit to vincenzopalazzo/lightning that referenced this issue Jul 3, 2022
@niftynei @vincenzopalazzo
df: check mempool/block for funding output on broadcast fail
39b6fa7 
If we can't broadcast the tx, confirm that it didn't end up in the
mempool or the utxo set before throwing an error.

Note that this doesn't protect us in the case where the funding
output has already been *spent*... but that's extremely rare, right?

Fixes ElementsProject#5296

Reported-By: @rustyrussell
Collab-With: @vincenzopalazzo
niftynei added a commit to vincenzopalazzo/lightning that referenced this issue Jul 7, 2022
@niftynei
df: check mempool/block for funding output on broadcast fail
8a70fc3 
If we can't broadcast the tx, confirm that it didn't end up in the
mempool or the utxo set before throwing an error.

Note that this doesn't protect us in the case where the funding
output has already been *spent*... but that's extremely rare, right?

Fixes ElementsProject#5296

Reported-By: @rustyrussell
Collab-With: @vincenzopalazzo
whitslack pushed a commit to whitslack/lightning that referenced this issue Oct 8, 2022
@niftynei @whitslack
df: check mempool/block for funding output on broadcast fail
290aa17 
If we can't broadcast the tx, confirm that it didn't end up in the
mempool or the utxo set before throwing an error.

Note that this doesn't protect us in the case where the funding
output has already been *spent*... but that's extremely rare, right?

Fixes ElementsProject#5296

Reported-By: @rustyrussell
Collab-With: @vincenzopalazzo
whitslack pushed a commit to whitslack/lightning that referenced this issue Oct 28, 2022
@niftynei @whitslack
df: check mempool/block for funding output on broadcast fail
e1a464e 
If we can't broadcast the tx, confirm that it didn't end up in the
mempool or the utxo set before throwing an error.

Note that this doesn't protect us in the case where the funding
output has already been *spent*... but that's extremely rare, right?

Fixes ElementsProject#5296

Reported-By: @rustyrussell
Collab-With: @vincenzopalazzo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niftynei niftynei

Labels
dualfunding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

df: check mempool/block for funding output on broadcast fail niftynei/lightning
2 participants
@rustyrussell @niftynei