Skip to content

opening failures leave peer turds #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rustyrussell opened this issue Dec 5, 2017 · 4 comments
Closed

opening failures leave peer turds #401

rustyrussell opened this issue Dec 5, 2017 · 4 comments

Comments

@rustyrussell
Copy link
Contributor

bitcoin@bilbo:~/.lightning$ lightning-cli getpeers
{ "peers" :
[
{ "state" : "OPENINGD", "netaddr" :
[ ], "peerid" : "03bc4b957d5ad27b797d6fffa863d74e7946723e67b9084842622fe5e635747569", "connected" : false },
{ "state" : "OPENINGD", "netaddr" :
[ ], "peerid" : "03bc4b957d5ad27b797d6fffa863d74e7946723e67b9084842622fe5e635747569", "connected" : false },
{ "state" : "CHANNELD_NORMAL", "netaddr" :
[ "148.252.86.248:53093" ], "peerid" : "02c28fdf8fed204522358ad1056e00f7fe6a0142d74f5589a172aeff93371c500d", "connected" : true, "owner" : "lightning_channeld", "channel" : "497346:551:1", "msatoshi_to_us" : 0, "msatoshi_total" : 80000000 },
{ "state" : "CHANNELD_NORMAL", "netaddr" :
[ ], "peerid" : "036c74ac746b3a314f698aa234100e13892275df1632d14cd605d89badfe2c707e", "connected" : false, "channel" : "497278:1604:1", "msatoshi_to_us" : 49800000, "msatoshi_total" : 50000000 },
{ "state" : "CHANNELD_AWAITING_LOCKIN", "netaddr" :
[ "64.71.8.130:55850" ], "peerid" : "0392de9959c87b521f1791a22ef42b60fb15eb9ec9036d46995d01a4c0f4ec0041", "connected" : true, "owner" : "lightning_channeld", "msatoshi_to_us" : 0, "msatoshi_total" : 70000000 } ] }

This was caused by trying to open twice with too little satoshis.
@instagibbs
Copy link
Contributor

ACK, many turds in my list

rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 11, 2017
@rustyrussell
test_lightningd: add test for funding failures.
b649f45 
We should not disconnect from a peer just because it fails opening; we
should return it to gossipd, and give a meaningful error.

Closes: ElementsProject#401
Signed-off-by: Rusty Russell <[email protected]>
cdecker pushed a commit to cdecker/lightning that referenced this issue Dec 12, 2017
@rustyrussell @cdecker
test_lightningd: add test for funding failures.
1b1d4a2 
We should not disconnect from a peer just because it fails opening; we
should return it to gossipd, and give a meaningful error.

Closes: ElementsProject#401
Signed-off-by: Rusty Russell <[email protected]>
cdecker pushed a commit to cdecker/lightning that referenced this issue Dec 13, 2017
@rustyrussell @cdecker
test_lightningd: add test for funding failures.
6889fe7 
We should not disconnect from a peer just because it fails opening; we
should return it to gossipd, and give a meaningful error.

Closes: ElementsProject#401
Signed-off-by: Rusty Russell <[email protected]>
jb55 pushed a commit to jb55/lightning that referenced this issue Dec 13, 2017
@rustyrussell @jb55
test_lightningd: add test for funding failures.
01defe3 
We should not disconnect from a peer just because it fails opening; we
should return it to gossipd, and give a meaningful error.

Closes: ElementsProject#401
Signed-off-by: Rusty Russell <[email protected]>
jb55 pushed a commit to jb55/lightning that referenced this issue Dec 16, 2017
@rustyrussell @jb55
test_lightningd: add test for funding failures.
6deac0a 
We should not disconnect from a peer just because it fails opening; we
should return it to gossipd, and give a meaningful error.

Closes: ElementsProject#401
Signed-off-by: Rusty Russell <[email protected]>
@jb55
Copy link
Collaborator

jb55 commented Jan 13, 2018

I'm still getting opening turds...

@jb55
Copy link
Collaborator

jb55 commented Jan 14, 2018

Some clues:

lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?
lightningd(30333): peer 023d8ab0d84c21979224213452117b0c1ff3605bdf0e9da478f93db11b06d3471c: activate_peer(OPENINGD) with no funding txid?

@ktorn
Copy link
Contributor

ktorn commented Jan 16, 2018

Same here, lots of of them due to failed channel opens, caused by mismatched fee thresholds (see #609).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jb55 @ktorn @rustyrussell @instagibbs