Added UserAgentFallback to App #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BridgeConnector.Socket.Emit("appGetUserAgentFallback"); | ||
|
|
||
| return taskCompletionSource.Task; | ||
| }).Result; |
There was a problem hiding this comment.
Hmm .Result can causes deadlocks. The cleanest implementation would be:
public Task GetUserAgentFallback
public void SetUserAgentFallback
Or what do you guys think?
There was a problem hiding this comment.
I think it would be a problem with functions that are called regularly during application runtime. I would leave it at Properties.
There was a problem hiding this comment.
I think some application design is important too... otherwise we would only have methods..
|
@Mandrakia Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UserAgentFallback to the App object