Skip to content

added /dotnet-configuration parameter for electronize start command #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dmitrya1979
Copy link

if your .net core project has several configurations use /dotnet-configuration parameter

electronize start /dotnet-configuration MacOsRelease

@GregorBiswanger
Copy link
Member

Please set /dotnet-configuration as an optional parameter for electronze start.

Maybe better if we can optionally store the configuration in the electron.manifest.json? Also have the possibility to store different electron.manifest.json here. This would simplify the organization for different environments considerably.

As example:

  • Create a additional manifest file: electronize init /manifest test
  • Start the app with your additional manifest file: electronize start /manifest electron.manifest.test.json
  • Build the app with your additional manifest file: electronize build /target win /manifest electron.manifest.test.json.

@robertmuehsig
Copy link
Collaborator

This seems to be related to #324

The start and build commands are related and they should support similar arguments. Either someone updates the PR 324.

I would say we close this PR and if someone is willing to implent it, the PR 324 way would be better IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants