Code cleanup prior to queue replacement #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
requested review from
mathieucarbou,
me-no-dev,
vortigont and
Copilot
|
@willmmiles : can you please rebase on main ? We had a standing PR that I have merged this morning to be able to work in esp-idf without Arudino. So there are now a little conflict to solve, sorry... We should be able to merge this cleanup PR after because there is no design change (I quickly went through the code but will do it more deeply once rebased). Thanks a lot for your work! |
The previous code tried to implement move-as-copy semantics, which can lead to unexpected behavior; and further it was not safe, as there was a risk of race conditions with the LwIP thread. Remove the unsafe function for now, and indicate to the compiler to check for it. If there's a strong need for a move operation in the future, the thread safety can be reviewed at that time.
Use a recursion-safe guard class for managing the LwIP lock. This will allow some improvements to reduce code duplication.
Use a friend class to ensure that private callbacks are not exposed to client code.
willmmiles
force-pushed
the
replace-queue-v2-part1
branch
from
be4f196 to
d3e5501
Compare
mathieucarbou
approved these changes
Apr 16, 2025
|
@willmmiles : fyi @me-no-dev will be able to have a look today or Friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of a replacment series for #21, consisting of removing unsafe interfaces and some internal cleanup prior to the queue structure change.