Skip to content

Microsoft.AspnetCore.Authentication.Google -> Use demo.duendesoftware.com #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

maartenba
Copy link
Member

@maartenba maartenba added this to the 2025-Q2 milestone May 12, 2025
@maartenba maartenba self-assigned this May 12, 2025
@maartenba maartenba added the documentation Improvements or additions to documentation label May 12, 2025
options.ClientSecret = builder.Configuration["Authentication:Google:ClientSecret"];
});
.AddGoogleOpenIdConnect(
authenticationScheme: GoogleOpenIdConnectDefaults.AuthenticationScheme,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need to set authenticatScheme - just displayName should be enough to change the way the button is rendered.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed unfortunately because of their funky method signature.

@maartenba maartenba changed the title Microsoft.AspnetCore.Authentication.Google -> Google.Apis.Auth.AspNetCore3 Microsoft.AspnetCore.Authentication.Google -> Use demo.duendesoftware.com May 13, 2025
@maartenba maartenba requested a review from josephdecock May 13, 2025 10:01
@maartenba
Copy link
Member Author

Can you make another pass? Pulled demo.duendesoftware.com up in the docs (but keeping Google as a second example in the quickstart)

@khalidabuhakmeh khalidabuhakmeh self-requested a review May 15, 2025 12:44
@maartenba maartenba merged commit 7647be8 into main May 15, 2025
5 of 6 checks passed
@maartenba maartenba deleted the mb/googleauth branch May 15, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants