specify default reason details, add tests

Author: phaym

.gitignore

@@ -104,3 +104,6 @@ verdaccio
 e2e/js/js-cdn/src/assets/devcycle.min.js
 e2e/js/js-cdn/playwright-report/
 e2e/js/js-esm/playwright-report/
+
+#opencode ai guidelines
+AGENTS.md

sdk/nodejs/__tests__/client.spec.ts

@@ -1,7 +1,12 @@
 /* eslint-disable @typescript-eslint/ban-ts-comment */
 import { DevCycleClient } from '../src/client'
 import { DevCycleUser } from '@devcycle/js-cloud-server-sdk'
-import { DVCCustomDataJSON } from '@devcycle/types'
+import {
+    DEFAULT_REASON_DETAILS,
+    DVCCustomDataJSON,
+    EVAL_REASON_DETAILS,
+    EVAL_REASONS,
+} from '@devcycle/types'
 import { EvalHook } from '../src/hooks/EvalHook'
 
 jest.mock('../src/bucketing')
@@ -80,6 +85,11 @@ describe('variable', () => {
         const variable = client.variable(user, 'test-key', false)
         expect(variable.value).toEqual(true)
         expect(variable.type).toEqual('Boolean')
+        expect(variable.eval).toEqual({
+            reason: EVAL_REASONS.TARGETING_MATCH,
+            details: EVAL_REASON_DETAILS.ALL_USERS,
+            target_id: 'mockTargetId',
+        })
 
         expect(client.variableValue(user, 'test-key', false)).toEqual(true)
     })
@@ -98,6 +108,10 @@ describe('variable', () => {
         const variable = client.variable(user, 'test-key2', false)
         expect(variable.value).toEqual(false)
         expect(variable.isDefaulted).toEqual(true)
+        expect(variable.eval).toEqual({
+            reason: EVAL_REASONS.DEFAULT,
+            details: DEFAULT_REASON_DETAILS.USER_NOT_TARGETED,
+        })
 
         // @ts-ignore
         client.bucketingLib.variableForUser_PB.mockReturnValueOnce(null)
@@ -110,6 +124,10 @@ describe('variable', () => {
         const variable = client.variable(user, 'test-key', 'test')
         expect(variable.value).toEqual('test')
         expect(variable.isDefaulted).toEqual(true)
+        expect(variable.eval).toEqual({
+            reason: EVAL_REASONS.DEFAULT,
+            details: DEFAULT_REASON_DETAILS.TYPE_MISMATCH,
+        })
 
         expect(client.variableValue(user, 'test-key', 'test')).toEqual('test')
     })

sdk/nodejs/src/__mocks__/bucketing.ts

@@ -1,11 +1,17 @@
 import { Exports, ProtobufTypes } from '@devcycle/bucketing-assembly-script'
+import { EVAL_REASON_DETAILS, EVAL_REASONS } from '@devcycle/types'
 
 const testVariable = {
     _id: 'test-id',
     value: true,
     type: 'Boolean',
     key: 'test-key',
     evalReason: null,
+    eval: {
+        reason: EVAL_REASONS.TARGETING_MATCH,
+        details: EVAL_REASON_DETAILS.ALL_USERS,
+        target_id: 'mockTargetId',
+    },
 }
 const buffer = ProtobufTypes.SDKVariable_PB.encode({
     _id: testVariable._id,
@@ -14,6 +20,7 @@ const buffer = ProtobufTypes.SDKVariable_PB.encode({
     boolValue: testVariable.value,
     doubleValue: 0,
     stringValue: '',
+    eval: testVariable.eval,
 }).finish()
 
 enum VariableType {

sdk/nodejs/src/client.ts

@@ -281,7 +281,7 @@ export class DevCycleClient<
         if (configVariable) {
             if (type === configVariable.type) {
                 options.value = configVariable.value as VariableTypeAlias<T>
-                options.eval = configVariable?.eval
+                options.eval = { ...configVariable?.eval }
             } else {
                 options.eval = {
                     reason: EVAL_REASONS.DEFAULT,
@@ -291,6 +291,11 @@ export class DevCycleClient<
                     `Type mismatch for variable ${key}. Expected ${type}, got ${configVariable.type}`,
                 )
             }
+        } else {
+            options.eval = {
+                reason: EVAL_REASONS.DEFAULT,
+                details: DEFAULT_REASON_DETAILS.USER_NOT_TARGETED,
+            }
         }
 
         return new DVCVariable(options)