Skip to content

Remove obsolete members that was marked so in 7.1 or earlier #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Remove obsolete members that was marked so in 7.1 or earlier #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e4af97
Remove obsoletes that were marked in 7.1 or older versions
alex-kulakov Jan 28, 2025
0901e6c
Merge branch 'master' into master-remove-obsoletes
alex-kulakov Apr 24, 2025
aeaa8d3
Improve changelog
alex-kulakov Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog/7.2.0-Beta-2-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
[main] Upgrade hints change names of constructors' string parameters for better understanding of what suppose to be in them.
[main] Improved string operations Trim/TrimStart/TrimEnd support
[main] Obsolete DomainConfiguration.DefauktForeignKeyMode const removed, the correctly named constant still exists
[main] Obsolete SqlPersistTask constructors removed
[main] Obsolete AggregateProvider constructor removed
[main] Obsolete CalculateProvider constructor removed
[mysql] SqlDml.NullIf function now correctly translated
[mysql] Improved support for string.PadLeft/PadRight opertaions
[sqlite] Fixed string.Lenght translation
Expand Down
6 changes: 0 additions & 6 deletions Orm/Xtensive.Orm/Orm/Configuration/DomainConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@ public class DomainConfiguration : ConfigurationBase
/// </summary>
public const DomainUpgradeMode DefaultUpgradeMode = DomainUpgradeMode.Default;

/// <summary>
/// Default <see cref="ForeignKeyMode"/> value.
/// </summary>
[Obsolete ("User DefaultForeignKeyMode")]
public const ForeignKeyMode DefauktForeignKeyMode = ForeignKeyMode.Default;

/// <summary>
/// Default <see cref="ForeignKeyMode"/> value.
/// </summary>
Expand Down
12 changes: 0 additions & 12 deletions Orm/Xtensive.Orm/Orm/Providers/CommandProcessing/SqlPersistTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,6 @@ public SqlPersistTask(PersistRequest request, IReadOnlyList<Tuple> tuples)
Tuples = tuples;
}

[Obsolete]
public SqlPersistTask(Key key, IEnumerable<PersistRequest> requestSequence, Tuple tuple)
: this(key, (requestSequence as IReadOnlyCollection<PersistRequest>)?? requestSequence.ToList(), tuple)
{
}

[Obsolete]
public SqlPersistTask(Key key, IEnumerable<PersistRequest> requestSequence, Tuple tuple, Tuple originalTuple, bool validateRowCount)
: this(key, (requestSequence as IReadOnlyCollection<PersistRequest>) ?? requestSequence.ToList(), tuple, originalTuple, validateRowCount)
{
}

public SqlPersistTask(Key key, IReadOnlyCollection<PersistRequest> requestSequence, Tuple tuple)
{
EntityKey = key;
Expand Down
12 changes: 0 additions & 12 deletions Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/AggregateProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,18 +190,6 @@ private static NotSupportedException AggregateNotSupported(Type sourceColumnType

// Constructors

/// <summary>
/// Initializes a new instance of this class.
/// </summary>
/// <param name="source">The <see cref="UnaryProvider.Source"/> property value.</param>
/// <param name="groupIndexes">The column indexes to group by.</param>
/// <param name="columnDescriptors">The descriptors of <see cref="AggregateColumns"/>.</param>
[Obsolete]
public AggregateProvider(CompilableProvider source, int[] groupIndexes, params AggregateColumnDescriptor[] columnDescriptors)
: this(source, groupIndexes, (IReadOnlyList<AggregateColumnDescriptor>) columnDescriptors)
{
}

/// <summary>
/// Initializes a new instance of this class.
/// </summary>
Expand Down
31 changes: 0 additions & 31 deletions Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/CalculateProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,37 +61,6 @@ protected override void Initialize()

// Constructors

/// <summary>
/// Initializes a new instance of this class.
/// </summary>
/// <param name="source">The <see cref="UnaryProvider.Source"/> property value.</param>
/// <param name="columnDescriptors">The descriptors of <see cref="CalculatedColumns"/>.</param>
[Obsolete]
public CalculateProvider(CompilableProvider source, params CalculatedColumnDescriptor[] columnDescriptors)
: this(source, false, columnDescriptors)
{
}

/// <summary>
/// Initializes a new instance of this class.
/// </summary>
/// <param name="source">The <see cref="UnaryProvider.Source"/> property value.</param>
/// <param name="isInlined">The <see cref="IsInlined"/> property value.</param>
/// <param name="columnDescriptors">The descriptors of <see cref="CalculatedColumns"/>.</param>
[Obsolete]
public CalculateProvider(CompilableProvider source, bool isInlined, params CalculatedColumnDescriptor[] columnDescriptors)
: base(ProviderType.Calculate, source)
{
IsInlined = isInlined;
var columns = new CalculatedColumn[columnDescriptors.Length];
for (int i = 0; i < columnDescriptors.Length; i++) {
var col = new CalculatedColumn(columnDescriptors[i], Source.Header.Length + i);
columns.SetValue(col, i);
}
CalculatedColumns = columns;
Initialize();
}

/// <summary>
/// Initializes a new instance of this class.
/// </summary>
Expand Down