Improves compatibility of certain async query extension methods with EntitySets #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added EntitySet as valid case of source to all ToXxxAsync extension tests - applied current formatting rules
Such as EntitySets. The wrapper allows to apply .ToArrayAsync/ToListAsync/ToHashSetAsync extension methods to EntitySets. Correct implementation of IAsyncEnumerable would take a lot of resources because many apis should support async operation, this approach less painfull, though has a caviar - in ClientProfile mode results does not contain local changes.
- added remark that methods cause query execution and that results may not include local changes in some cases. - similar methods grouped in regions
This was referenced Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add special wrapper for queries that are not IAsyncEnumerable natively, such as EntitySets. The wrapper allows to apply .ToArrayAsync/ToListAsync/ToHashSetAsync extension methods to EntitySets. Correct implementation of IAsyncEnumerable would take a lot of resources because many APIs should support async operations, this approach less painful, though has a caviar - in ClientProfile mode results does not contain local changes.