Skip to content

SqlServer: Both US English and British English are considered English #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2023
Merged

SqlServer: Both US English and British English are considered English #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d4393
SqlServer: Both US English and British English are considered english
alex-kulakov Mar 20, 2023
1702462
Improve changelog
alex-kulakov Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ChangeLog/6.0.12_dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
[main] Addressed DataTypeCollection.Add method issue of wrong adding storage-specifid types to the collection
[main] Addressed DataTypeCollection.Add method issue of wrong adding storage-specifid types to the collection
[sqlserver] Sql error messages for British English are correctly parsed
3 changes: 2 additions & 1 deletion Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/DriverFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ private static ErrorMessageParser CreateMessageParser(SqlServerConnection connec
bool isEnglish;
using (var command = connection.CreateCommand()) {
command.CommandText = LangIdQuery;
isEnglish = command.ExecuteScalar().ToString()=="0";
var langId = (short) command.ExecuteScalar();
isEnglish = langId == 0 || langId == 23;
}
var templates = new Dictionary<int, string>();
using (var command = connection.CreateCommand()) {
Expand Down