Fix closure type instance caching problem (issue #224) #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AllocateParameterAndReplacer method returns back its responsibility declared in name - Checking for ability to cache query is moved to method that caches query - No two calls for queryTarget.GetType(), it is cached when AllocateParameterAndReplacer method is called, since the method called only when caching is needed we can use cached type later on in IsQueryCacheable method - all structs allowed in closure type
+ minor changes of test enitites
|
@SergeiPavlov , since you're the person who created this check, please take a look. |
SergeiPavlov
previously approved these changes
Jun 24, 2022
As I see local collections trigger ItemToTupleConverter to be built and closure type instance can be captured within ParameterizedQuery.
Also revert previous changes of conditional caching
alex-kulakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes capture of closure type instance declared in #224, reverts previous changes made in #225