Merge pull request #403 from DataObjects-NET/7.1-mutable-hashset-bug

Fix of race condition with TranslatorState.NonVisitableExpressions

Author: alex-kulakov

ChangeLog/7.1.3_dev.txt

@@ -0,0 +1 @@
+[main] Addressed race condition issue with TranslatorState.NonVisitableExpressions

Orm/Xtensive.Orm/Orm/Linq/LocalCollectionKeyTypeExtractor.cs

@@ -24,14 +24,14 @@ public static Type Extract(BinaryExpression expression)
         return key.EntityType.UnderlyingType;
       }
 
-      var expr = VisitBinaryExpession(expression);
+      var expr = VisitBinaryExpression(expression);
       if (expr.Type.IsSubclassOf(WellKnownOrmTypes.Entity)) {
         return expr.Type;
       }
       throw new NotSupportedException(string.Format(Strings.ExCurrentTypeXIsNotSupported, expr.Type));
     }
 
-    private static Expression VisitBinaryExpession(BinaryExpression binaryExpression)
+    private static Expression VisitBinaryExpression(BinaryExpression binaryExpression)
     {
       if (!(binaryExpression.Right is MemberExpression memberExpression)) {
         throw new InvalidOperationException(string.Format(Strings.ExCantConvertXToY, binaryExpression.Type, typeof(MemberExpression)));

Orm/Xtensive.Orm/Orm/Linq/Translator.Queryable.cs

@@ -33,7 +33,9 @@ internal sealed partial class Translator : QueryableVisitor
     private readonly TranslatorContext context;
     private readonly bool tagsEnabled;
 
-    internal TranslatorState State { get; private set; } = TranslatorState.InitState;
+    internal TranslatorState State { get; private set; } = new(TranslatorState.InitState) {
+      NonVisitableExpressions = new()
+    };
 
     protected override Expression VisitConstant(ConstantExpression c)
     {

Orm/Xtensive.Orm/Orm/Linq/TranslatorState.cs

@@ -70,7 +70,7 @@ public TranslatorScope(Translator translator)
 
 
     /// <summary>
-    /// Expessions that were constructed during original expression translation
+    /// Expressions that were constructed during original expression translation
     /// and aim to replace original parts so they are avoidable to visit by Linq translator.
     /// </summary>
     /// <remarks>