Skip to content

feat: Add FIPS layers to layers-gov.json #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented May 21, 2025

What does this PR do?

  1. In generate_layers_json.sh, add layer names Datadog-Extension-FIPS and Datadog-Extension-ARM-FIPS so the FIPS layers for GovCloud can be added to layers-gov.json
  2. Reformat the lists LAYER_NAMES and JSON_LAYER_NAMES. Make each value have a single line for better readability.

Motivation

This is the first step towards supporting FIPS in Serverless Plugin.

Testing Guidelines

Run aws-vault exec sso-govcloud-us1-fed-engineering -- ./scripts/generate_layers_json.sh -g, which updates layers-gov.json.

Additional Notes

The next PR will add a parameter to allow choosing the FIPS layer.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner May 21, 2025 20:45
@lym953 lym953 requested a review from TalUsvyatsky May 21, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants