Skip to content

fix(tracing/internal): fix encoding of propagated internal tags #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

brettlangdon
Copy link
Member

= is an allowed character in a tag value, but not a tag key.

Fixes: #3318

@brettlangdon brettlangdon requested a review from a team as a code owner February 24, 2022 13:27
@brettlangdon
Copy link
Member Author

@Mergifyio backport 0.x

@brettlangdon
Copy link
Member Author

@Mergifyio backport 0.58

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.x

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.58

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@brettlangdon
Copy link
Member Author

@Mergifyio backport 0.x59

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.x59

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@codecov-commenter
Copy link

Codecov Report

Merging #3320 (50473fe) into 1.x (02199af) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.x    #3320   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         615      615           
  Lines       46580    46580           
=======================================
  Hits        37043    37043           
  Misses       9537     9537           
Impacted Files Coverage Δ
tests/tracer/test_tagset.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02199af...50473fe. Read the comment docs.

@brettlangdon brettlangdon merged commit b2819af into 1.x Feb 24, 2022
@brettlangdon brettlangdon deleted the brettlangdon/fix.3318 branch February 24, 2022 14:38
@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.x59

❌ No backport have been created

  • Backport to branch 0.x59 failed: Branch not found

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.58

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.x

✅ Backports have been created

@brettlangdon
Copy link
Member Author

@Mergifyio backport 0.59

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 0.59

✅ Backports have been created

brettlangdon added a commit that referenced this pull request Feb 24, 2022
… (#3324)

Fixes: #3318
(cherry picked from commit b2819af)

Co-authored-by: Brett Langdon <[email protected]>
brettlangdon added a commit that referenced this pull request Feb 24, 2022
… (#3323)

Fixes: #3318
(cherry picked from commit b2819af)

Co-authored-by: Brett Langdon <[email protected]>
brettlangdon added a commit that referenced this pull request Feb 24, 2022
… (#3322)

Fixes: #3318
(cherry picked from commit b2819af)

Co-authored-by: Brett Langdon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TagsetEncodeError, failed to encode x-datadog-tags
4 participants