refactor(profiling): type pprof exporter and fix type comparison (backport #2987) #3062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
There was an ongoing issue wih the pprof encode mixing type between strings, ints and None when dealing with labels. This has been fixed in multiple places and in multiple occasion, but there were still holes. When encoding Events to pprof, they are grouped by event fields. Those fields might be str, int or something else. In order to group those events, all the fields used for grouping must be: 1. hashable (because we index in a dict) 2. sortable (because we sort event to have reproducible) 3. string (because we store those as labels in pprof) The problem is that most value type used in events are hashable (None, int or str) but sortability often fails when one of the field is None: you can't compare `int` with `None`, making sorted() call fails like in #2962. As we need string in the end, the fix is to convert everything to strings as soon as possible when grouping events: that makes sure conditions 1, 2 and 3 are validated ASAP and everything works. To do this, the code has been updated and typed to catch any future error. Fixes #2962 Co-authored-by: Brett Langdon <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 6520212)
jd
added
the
changelog/no-changelog
jd
approved these changes
Dec 10, 2021
This was referenced Dec 10, 2021
brettlangdon
approved these changes
Dec 10, 2021
Codecov Report
@@ Coverage Diff @@
## 0.56 #3062 +/- ##
==========================================
- Coverage 84.37% 84.34% -0.04%
==========================================
Files 623 624 +1
Lines 45312 45337 +25
==========================================
+ Hits 38234 38238 +4
- Misses 7078 7099 +21
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2987 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com