Remove non actionnable telemetry logs (#3270)

* chore: remove non actionnable telemetry logs

* Revert most useful integration error submissions

Guard against file exists before submitting

Signed-off-by: Bob Weinand <[email protected]>

---------

Signed-off-by: Bob Weinand <[email protected]>
Co-authored-by: Bob Weinand <[email protected]>

Author: dubloom

ext/autoload_php_files.c

@@ -102,7 +102,7 @@ int dd_execute_php_file(const char *filename, zval *result, bool try) {
         LOGEV(WARN, {
             if (PG(last_error_message)) {
                 log("Error raised in autoloaded file %s: %s in %s on line %d", filename, LAST_ERROR_STRING, LAST_ERROR_FILE, PG(last_error_lineno));
-                if (get_global_DD_INSTRUMENTATION_TELEMETRY_ENABLED() && get_DD_TELEMETRY_LOG_COLLECTION_ENABLED()) {
+                if (get_global_DD_INSTRUMENTATION_TELEMETRY_ENABLED() && get_DD_TELEMETRY_LOG_COLLECTION_ENABLED() && VCWD_ACCESS(filename, R_OK) == 0) {
                     INTEGRATION_ERROR_TELEMETRY(ERROR, "Error raised in autoloaded file %s: %s in %s on line %d", filename, LAST_ERROR_STRING, LAST_ERROR_FILE, PG(last_error_lineno));
                 }
             }
@@ -111,7 +111,7 @@ int dd_execute_php_file(const char *filename, zval *result, bool try) {
                 const char *type = ex->ce->name->val;
                 const char *msg = instanceof_function(ex->ce, zend_ce_throwable) ? ZSTR_VAL(zai_exception_message(ex)) : "<exit>";
                 log("%s thrown in autoloaded file %s: %s", type, filename, msg);
-                if (get_global_DD_INSTRUMENTATION_TELEMETRY_ENABLED() && get_DD_TELEMETRY_LOG_COLLECTION_ENABLED()) {
+                if (get_global_DD_INSTRUMENTATION_TELEMETRY_ENABLED() && get_DD_TELEMETRY_LOG_COLLECTION_ENABLED() && VCWD_ACCESS(filename, R_OK) == 0) {
                     INTEGRATION_ERROR_TELEMETRY(ERROR, "%s thrown in autoloaded file %s: %s", type, filename, msg);
                 }
             }

ext/integrations/integrations.c

@@ -98,9 +98,6 @@ static void dd_invoke_integration_loader_and_unhook_posthook(zend_ulong invocati
                 zend_class_entry *ce = zend_lookup_class(aux->classname);
                 if (!ce) {
                     LOG(WARN, "Error loading deferred integration %s: Class not loaded and not autoloadable", ZSTR_VAL(aux->classname));
-                    if (get_global_DD_INSTRUMENTATION_TELEMETRY_ENABLED() && get_DD_TELEMETRY_LOG_COLLECTION_ENABLED()) {
-                        INTEGRATION_ERROR_TELEMETRY(WARN, "Error loading deferred integration %s: Class not loaded and not autoloadable", ZSTR_VAL(aux->classname));
-                    }
                     success = true;
                     break;
                 }