Skip to content

Fix iast for mysq-run-stores PR #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented May 29, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented May 29, 2025

Overall package size

Self size: 9.47 MB
Deduped: 103.49 MB
No deduping: 104.01 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.18%. Comparing base (1639cf7) to head (2d26547).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-instrumentations/src/mysql.js 62.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5787      +/-   ##
==========================================
- Coverage   79.38%   79.18%   -0.20%     
==========================================
  Files         522      518       -4     
  Lines       23811    23539     -272     
==========================================
- Hits        18902    18640     -262     
+ Misses       4909     4899      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 29, 2025

Datadog Report

Branch report: ugaitz/fix-mysql-run-stores-iast-pr
Commit report: 9f2a0fa
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1152 Passed, 0 Skipped, 21m 50.87s Total Time

@pr-commenter
Copy link

pr-commenter bot commented May 29, 2025

Benchmarks

Benchmark execution time: 2025-05-29 08:59:42

Comparing candidate commit 2d26547 in PR branch ugaitz/fix-mysql-run-stores-iast-pr with baseline commit d5ae99f in branch mysql-run-stores.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1276 metrics, 47 unstable metrics.

@uurien uurien force-pushed the ugaitz/fix-mysql-run-stores-iast-pr branch from 50f9403 to cf4220d Compare May 29, 2025 08:46
@uurien uurien force-pushed the ugaitz/fix-mysql-run-stores-iast-pr branch from cf4220d to 2d26547 Compare May 29, 2025 08:50
@uurien uurien marked this pull request as ready for review May 29, 2025 08:55
@uurien uurien requested review from a team as code owners May 29, 2025 08:55
@rochdev rochdev force-pushed the mysql-run-stores branch from 5541c9b to afb0a31 Compare May 29, 2025 16:28
Base automatically changed from mysql-run-stores to master June 2, 2025 16:26
@rochdev
Copy link
Member

rochdev commented Jun 2, 2025

Closing as I ended up reverting the change instead since the payload didn't actually need to move to a property. Thanks for figuring out what the issue was super quickly!

@rochdev rochdev closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants