for running benchmarks, retrieve GH token scoping the benchmarking-platform repo

Author: igoragoli

.gitlab/benchmarks/microbenchmarks.yml

@@ -2,10 +2,11 @@
   before_script:
     - |
       set +e
-      error_output=$({ dd-octo-sts token --scope DataDog/dd-trace-dotnet --policy gitlab.github-access.read-contents > "/tmp/github-token"; } 2>&1)
+      echo "Attempting to retrieve a GitHub token for scope '$DDOCTOSTS_SCOPE' with policy '$DDOCTOSTS_POLICY' with dd-octo-sts..."
+      error_output=$({ dd-octo-sts token --scope $DDOCTOSTS_SCOPE --policy $DDOCTOSTS_POLICY > "/tmp/github-token"; } 2>&1)
       exit_code=$?
       if [ $exit_code -ne 0 ]; then
-        echo "ERROR: Failed to retrieve a GitHub token with dd-octo-sts gitlab.github-access.read-contents policy."
+        echo "ERROR: Failed to retrieve GitHub token."
         echo "Original error: $error_output"
         echo "Continuing execution anyway..."
       fi
@@ -26,6 +27,11 @@ build-dd-trace-dotnet-microbenchmarks-ami:
     DDOCTOSTS_ID_TOKEN:
       aud: dd-octo-sts
   variables:
+    # Allows ephemeral instances to read content from dd-trace-dotnet
+    # This is not strictly necessary in the current AMI build
+    DDOCTOSTS_SCOPE: "DataDog/dd-trace-dotnet"
+    DDOCTOSTS_POLICY: "gitlab.github-access.read-contents"
+
     AWS_REGION: "us-east-1"
 
     # Branch containing a provision for building the AMI
@@ -75,6 +81,10 @@ run-benchmarks:
   rules:
     - when: on_success
   variables:
+    # Allows ephemeral instances to read content from benchmarking-platform
+    DDOCTOSTS_SCOPE: "DataDog/benchmarking-platform"
+    DDOCTOSTS_POLICY: "gitlab.github-access.read-contents"
+
     AWS_REGION: "us-east-1"
 
     # Branch containing 1. scripts to launch Windows benchmarks on ephemeral 
@@ -87,10 +97,10 @@ run-benchmarks:
 
     # Whether to cleanup ephemeral instances after benchmarks are run
     CLEANUP: "true"
-
   before_script:
     - !reference [.dd-octo-sts-setup, before_script]
   script:
+    - export GITHUB_TOKEN=$(cat /tmp/github-token)
     - git clone --branch $BP_INFRA_BENCHMARKING_PLATFORM_BRANCH https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/benchmarking-platform platform
     - ./platform/steps/run-windows-benchmarks.sh
   after_script: