Skip to content

Ensure dummy metadata segment is json serializable. #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

purple4reina
Copy link
Contributor

@purple4reina purple4reina commented Dec 4, 2023

Fixes error TypeError: Object of type Context is not JSON serializable #402

What does this PR do?

Fixes #402

When creating the xray metadata subsegment, we must pass a json serializable object. Unfortunately, a ddtrace.context.Context object is not json serializable.

Because the create_dd_dummy_metadata_subsegment method is used in other locations as well, we must convert the ddtrace.context.Context object before calling this method.

Motivation

Testing Guidelines

The test that I added passes with v82 of the layer but fails with v83 and v84. The fact that it again passes indicates to me that this fix will work.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@purple4reina purple4reina requested a review from a team as a code owner December 4, 2023 20:50
@purple4reina purple4reina force-pushed the rey.abolofia/bug-context branch from 199783c to dc18646 Compare December 4, 2023 21:22
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purple4reina purple4reina force-pushed the rey.abolofia/bug-context branch from dc18646 to d8c3447 Compare December 4, 2023 21:42
Fixes error `TypeError: Object of type Context is not JSON serializable`
#402
@purple4reina purple4reina force-pushed the rey.abolofia/bug-context branch from d8c3447 to 81720bb Compare December 5, 2023 17:26
@purple4reina purple4reina merged commit e8896d1 into main Dec 5, 2023
@purple4reina purple4reina deleted the rey.abolofia/bug-context branch December 5, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Bug with Dummy Metadata Subsegments
2 participants