Skip to content

Defer trace context extraction to ddtrace. #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Defer trace context extraction to ddtrace. #391

merged 3 commits into from
Nov 21, 2023

Conversation

purple4reina
Copy link
Contributor

@purple4reina purple4reina commented Nov 13, 2023

SVLS-3936

What does this PR do?

Instead of manually extracting trace context from inbound payloads, defer that responsibility to dd-trace-py. This allows us to support w3c trace context headers.

Motivation

Support for w3c trace context headers, why implement this extraction when the tracer has already done it.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@purple4reina purple4reina requested a review from a team as a code owner November 13, 2023 19:16
@purple4reina purple4reina changed the title Rey.abolofia/w3c Defer trace context extraction to ddtrace. Nov 13, 2023
@purple4reina purple4reina force-pushed the rey.abolofia/w3c branch 8 times, most recently from ffd0be5 to 46a4766 Compare November 13, 2023 21:27
@purple4reina purple4reina force-pushed the rey.abolofia/w3c branch 16 times, most recently from 9c7042c to 77736c9 Compare November 14, 2023 20:41
@astuyve astuyve merged commit 60ab01c into main Nov 21, 2023
@astuyve astuyve deleted the rey.abolofia/w3c branch November 21, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants