Skip to content

breaking: bump dd trace to 1.2.1 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ When opening an issue, include the Datadog Lambda Library version, Python versio

You can also open an issue for a feature request.

## Major Version Notes

### 4.x

- `dd-trace` upgraded from 0.61 to 1.2, full release notes are available [here](https://ddtrace.readthedocs.io/en/stable/release_notes.html#v1-0-0)
- `get_correlation_ids()` has been changed to `get_log_correlation_context()`, which now returns a dictionary containing the active `span_id`, `trace_id`, as well as `service` and `env`.

## Contributing

If you find an issue with this package and have a fix, please feel free to open a pull request following the [procedures](CONTRIBUTING.md).
Expand Down
6 changes: 3 additions & 3 deletions datadog_lambda/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ def get_dd_trace_context():
def set_correlation_ids():
"""
Create a dummy span, and overrides its trace_id and span_id, to make
ddtrace.helpers.get_correlation_ids() return the correct ids for both
ddtrace.helpers.get_log_correlation_context() return a dict containing the correct ids for both
auto and manual log correlations.

TODO: Remove me when Datadog tracer is natively supported in Lambda.
Expand All @@ -453,8 +453,8 @@ def inject_correlation_ids():
Override the formatter of LambdaLoggerHandler to inject datadog trace and
span id for log correlation.

For manual injections to custom log handlers, use `ddtrace.helpers.get_correlation_ids`
to retrieve correlation ids (trace_id, span_id).
For manual injections to custom log handlers, use `ddtrace.helpers.get_log_correlation_context`
to retrieve a dict containing correlation ids (trace_id, span_id).
"""
# Override the log format of the AWS provided LambdaLoggerHandler
root_logger = logging.getLogger()
Expand Down
Loading