Skip to content

Support lambda function URLs #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions datadog_lambda/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,9 @@ def create_inferred_span(event, context):
):
logger.debug("API Gateway event detected. Inferring a span")
return create_inferred_span_from_api_gateway_event(event, context)
elif event_source.equals(EventTypes.LAMBDA_FUNCTION_URL):
logger.debug("Function URL event detected. Inferring a span")
return create_inferred_span_from_lambda_function_url_event(event, context)
elif event_source.equals(
EventTypes.API_GATEWAY, subtype=EventSubtypes.HTTP_API
):
Expand Down Expand Up @@ -546,6 +549,38 @@ def create_inferred_span(event, context):
return None


def create_inferred_span_from_lambda_function_url_event(event, context):
request_context = event["requestContext"]
domain = request_context["domainName"]
method = request_context["http"]["method"]
path = request_context["http"]["path"]
resource = "{0} {1}".format(method, path)
tags = {
"operation_name": "aws.lambda.url",
"http.url": domain + path,
"endpoint": path,
"http.method": method,
"resource_names": domain + path,
"request_id": context.aws_request_id,
}
request_time_epoch = request_context["timeEpoch"]
args = {
"service": domain,
"resource": resource,
"span_type": "http",
}
tracer.set_tags(
{"_dd.origin": "lambda"}
) # function urls don't count as lambda_inferred,
# because they're in the same service as the inferring lambda function
span = tracer.trace("aws.lambda.url", **args)
InferredSpanInfo.set_tags(tags, tag_source="self", synchronicity="sync")
if span:
span.set_tags(tags)
span.start = request_time_epoch / 1000
return span


def is_api_gateway_invocation_async(event):
return (
"headers" in event
Expand Down
53 changes: 45 additions & 8 deletions datadog_lambda/trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class EventTypes(_stringTypedEnum):
CLOUDFRONT = "cloudfront"
DYNAMODB = "dynamodb"
KINESIS = "kinesis"
LAMBDA_FUNCTION_URL = "lambda-function-url"
S3 = "s3"
SNS = "sns"
SQS = "sqs"
Expand Down Expand Up @@ -115,6 +116,10 @@ def parse_event_source(event: dict) -> _EventSource:

request_context = event.get("requestContext")
if request_context and request_context.get("stage"):
if "domainName" in request_context and detect_lambda_function_url_domain(
request_context.get("domainName")
):
return _EventSource(EventTypes.LAMBDA_FUNCTION_URL)
event_source = _EventSource(EventTypes.API_GATEWAY)
if "httpMethod" in event:
event_source.subtype = EventSubtypes.API_GATEWAY
Expand Down Expand Up @@ -160,6 +165,14 @@ def parse_event_source(event: dict) -> _EventSource:
return event_source


def detect_lambda_function_url_domain(domain: str) -> bool:
# e.g. "etsn5fibjr.lambda-url.eu-south-1.amazonaws.com"
domain_parts = domain.split(".")
if len(domain_parts) < 2:
return False
return domain_parts[1] == "lambda-url"


def parse_event_source_arn(source: _EventSource, event: dict, context: Any) -> str:
"""
Parses the trigger event for an available ARN. If an ARN field is not provided
Expand All @@ -186,6 +199,18 @@ def parse_event_source_arn(source: _EventSource, event: dict, context: Any) -> s
aws_arn, account_id, distribution_id
)

# e.g. arn:aws:lambda:<region>:<account_id>:url:<function-name>:<function-qualifier>
if source.equals(EventTypes.LAMBDA_FUNCTION_URL):
function_name = ""
if len(split_function_arn) >= 7:
function_name = split_function_arn[6]
function_arn = f"arn:aws:lambda:{region}:{account_id}:url:{function_name}"
function_qualifier = ""
if len(split_function_arn) >= 8:
function_qualifier = split_function_arn[7]
function_arn = function_arn + f":{function_qualifier}"
return function_arn

# e.g. arn:aws:apigateway:us-east-1::/restapis/xyz123/stages/default
if source.event_type == EventTypes.API_GATEWAY:
request_context = event.get("requestContext")
Expand Down Expand Up @@ -275,23 +300,35 @@ def extract_trigger_tags(event: dict, context: Any) -> dict:
if event_source_arn:
trigger_tags["function_trigger.event_source_arn"] = event_source_arn

if event_source.event_type in [EventTypes.API_GATEWAY, EventTypes.ALB]:
if event_source.event_type in [
EventTypes.API_GATEWAY,
EventTypes.ALB,
EventTypes.LAMBDA_FUNCTION_URL,
]:
trigger_tags.update(extract_http_tags(event))

return trigger_tags


def extract_http_status_code_tag(trigger_tags, response):
"""
If the Lambda was triggered by API Gateway or ALB add the returned status code
If the Lambda was triggered by API Gateway, Lambda Function URL, or ALB add the returned status code
as a tag to the function execution span.
"""
is_http_trigger = trigger_tags and (
trigger_tags.get("function_trigger.event_source") == "api-gateway"
or trigger_tags.get("function_trigger.event_source")
== "application-load-balancer"
)
if not is_http_trigger:
if trigger_tags is None:
return
str_event_source = trigger_tags.get("function_trigger.event_source")
# it would be cleaner if each event type was a constant object that
# knew some properties about itself like this.
str_http_triggers = [
et.value
for et in [
EventTypes.API_GATEWAY,
EventTypes.LAMBDA_FUNCTION_URL,
EventTypes.ALB,
]
]
if str_event_source not in str_http_triggers:
return

status_code = "200"
Expand Down