-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Pretty print JSON for python. Fix missing regular expressions for masking out ephemeral information #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
b911dc9
6a8afda
f59a9a5
46cc279
41c309a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
'use strict' | ||
|
||
var readline = require('readline'); | ||
var rl = readline.createInterface({ | ||
input: process.stdin, | ||
output: process.stdout, | ||
terminal: false | ||
}); | ||
|
||
rl.on('line', function(line){ | ||
try { | ||
const obj = JSON.parse(line) | ||
console.log(JSON.stringify(obj, null, 2)) | ||
} catch (e) { | ||
console.log(line) | ||
} | ||
}) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,6 @@ provider: | |
DD_TRACE_ENABLED: true | ||
DD_API_KEY: ${env:DD_API_KEY} | ||
DD_TRACE_MANAGED_SERVICES: true | ||
DD_CAPTURE_LAMBDA_PAYLOAD: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you remove this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I inadvertently added it when I wrote the feature, but it includes all headers and payload data that is complex to mask out, so I removed it now. I think my introduction of this is what led to the tests being in the state they're in now. |
||
lambdaHashingVersion: 20201221 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Version 3 doesn't require us to use lambdaHashingVersion anymore. Should we remove it or update it? https://www.serverless.com/framework/docs/guides/upgrading-v3#lambda-hashing-algorithm There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will remove, thanks! |
||
timeout: 15 | ||
deploymentBucket: | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏