Rewrite UPD client when the extension is present to avoid loading datadogpy #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianchu
reviewed
Aug 31, 2021
| @@ -1,16 +1,12 @@ | |||
| from datadog_lambda.stats_writer import StatsWriter | |||
| from datadog import initialize, statsd | |||
| from datadog_lambda.dogstatsd import statsd | |||
There was a problem hiding this comment.
Can you add a comment in the other place (threadstats_writer?) where datadog is lazy loaded? just so people don't accidentally get import datadog into the critical path in the future?
There was a problem hiding this comment.
Good idea! I've updated both files with the comment. In threadstats_writer, there is no need to lazy load datadog as this file is lazy loaded itself here : https://github.com/DataDog/datadog-lambda-python/blob/main/datadog_lambda/metric.py#L30
tianchu
approved these changes
Aug 31, 2021
tianchu
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not load
datadogpywhen the extension is detected.Basically this PR duplicates the Dogstatd from
datadogpybut in a super light versionMotivation
Cold start duration improvements
Testing Guidelines
Unit tests + integration tests
Types of Changes
Check all that apply