Prepare for requests removal : add 100% unit test coverage on extension.py #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhinsch
reviewed
Aug 27, 2021
tests/test_extension.py
Outdated
| httpretty.disable() | ||
|
|
||
| @patch("datadog_lambda.extension.EXTENSION_PATH", os.path.abspath(__file__)) | ||
| def test_flush_ko(self): |
There was a problem hiding this comment.
I would say flush_not_ok -- ko means "knockout" as in boxing
There was a problem hiding this comment.
ahah alright! thanks for the link, I'll update it
nhinsch
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
requestswill be removed, but sinceextension.pywas not tested, this PR adds 100% unit test coverage to have a better confidence for the actual removalTesting Guidelines
Additional Notes
Types of Changes
Check all that apply