Skip to content

Check extension exists before calling hello route #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Changes logic for extension detection, to first check if the extension exists on disk. This is consistent with behavior in the node layer.

Motivation

Without this check, if a proxy is enabled on the lambda, it's possible that local host connections to the extension will be redirected through the proxy, incorrectly marking the extension as detected.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner June 4, 2021 03:39
@DarcyRaynerDD DarcyRaynerDD merged commit 2ca873e into main Jun 4, 2021
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-extension-detection branch June 4, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants