Skip to content

catch xray subsegment creation exceptions #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2021

Conversation

DylanLovesCoffee
Copy link
Contributor

What does this PR do?

Wraps logic that creates the dummy dd Xray subsegment in a try...except and logs the error.

Motivation

Issue raised where xray can't create a segment in Govcloud at times. This leads to xray being unable to create a subsegment and the function fails trying to write metadata to a None object.

Testing Guidelines

Testing run automatically via github actions.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner May 25, 2021 17:50
Copy link
Member

@srosenthal-dd srosenthal-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It worked perfectly! 💻 🐶 ❤️

@DylanLovesCoffee DylanLovesCoffee merged commit d90d1a5 into main May 26, 2021
@DylanLovesCoffee DylanLovesCoffee deleted the dylan/fix-xray-govcloud branch May 26, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants