Fix issue with stats d method being called #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we have to mask out the python version in the user-agent |
tianchu
reviewed
May 10, 2021
datadog_lambda/metric.py
Outdated
| class StatsDWrapper: | ||
| class StatsWriter: | ||
| def distribution(self, metric_name, value, tags=[], timestamp=None): | ||
| pass |
There was a problem hiding this comment.
Shall we raise NotImplementedError?
There was a problem hiding this comment.
tianchu
reviewed
May 10, 2021
datadog_lambda/metric.py
Outdated
| """ | ||
| Wraps StatsD calls, to give an identical interface to ThreadStats | ||
| Wraps StatsD calls, creates a common |
tianchu
approved these changes
May 10, 2021
tianchu
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Abstracts ThreadStats and StatsD metric submission into ThreadStatsWriter and StatsDWriter classes, which share an interface.
Motivation
Fixes #139
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply