Skip to content

Use latest setuptools version supported for each Python version #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

sfirrin
Copy link
Contributor

@sfirrin sfirrin commented Mar 31, 2021

What does this PR do?

Upgrades our pinned setuptools to the latest supported for each Python version.

setuptools dropped support for Python 2 in version 45 (link), so we need to specify an older version (44.1.1) for Python 2. This was done using the python_version environment marker documented here.

Motivation

#104

Testing Guidelines

Working as expected in the integration tests where we can see the older version is used for Python 2 and the newer version is used for Python 3.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@sfirrin sfirrin requested a review from a team as a code owner March 31, 2021 15:10
@sfirrin sfirrin merged commit a409c8f into main Apr 1, 2021
@sfirrin sfirrin deleted the stephenf/update-setuptools branch April 1, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants