Skip to content

Get status code from AWS Chalice response #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

tianchu
Copy link
Collaborator

@tianchu tianchu commented Mar 10, 2021

What does this PR do?

Fix AttributeError: 'Response' object has no attribute 'get' when used in an AWS Chalice project by making the code more robust. AWS Chalice function returns a Response object instead of a dict.

Motivation

Make datadog-lambda work for AWS Chalice projects.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@tianchu tianchu requested a review from a team as a code owner March 10, 2021 03:39
@tianchu tianchu force-pushed the tian.chu/fix-get-status-code branch from 3b04032 to 70148fd Compare March 10, 2021 04:01
Copy link
Contributor

@DylanLovesCoffee DylanLovesCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tianchu tianchu merged commit e44bc02 into main Mar 10, 2021
@tianchu tianchu deleted the tian.chu/fix-get-status-code branch March 10, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants