Skip to content

Relax datadog version requirement? #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stpierre opened this issue Oct 7, 2022 · 3 comments
Closed

Relax datadog version requirement? #253

stpierre opened this issue Oct 7, 2022 · 3 comments

Comments

@stpierre
Copy link

stpierre commented Oct 7, 2022

Expected Behavior

I should be able to use this library with a wider range of datadog library versions.

Actual Behavior

In order to install the latest datadog_lambda, you must be running exactly datadog==0.41; you cannot run with a newer version. It would be nice if a range were supported.

pyproject.toml specifies:

datadog = "^0.41"

The ^ makes me suspect that someone perhaps intended to support datadog>=0.41, <1, but poetry interprets ^ a bit differently when the first digit is a 0. Happy to put in a PR to fix that if the desired behavior can be confirmed.

Steps to Reproduce the Problem

  1. pip install datadog_lambda==4.62.0 datadog==0.44.0

Specifications

  • Datadog Lambda Layer version: 62
  • Python version: Any
@Knifa
Copy link

Knifa commented Nov 29, 2022

Would appreciate this as well! We're having to run a fork of this with the version bumped to keep this happy alongside some of our internal libraries. 😅

@vschurink
Copy link

can this be updated please? our renovate borks every datadog or lambda pipy update because of this 'incompatibility'. This seems like an easy fix :)

filip-halemba added a commit to filip-halemba/datadog-lambda-python that referenced this issue Jan 2, 2023
It seems to me that the version is not intentionally locked to the range >= 0.41, < 0.42, and it is more a matter of the fact that poetry treats versions that start with `0` differently when using `^` ([docs](https://python-poetry.org/docs/dependency-specification/#caret-requirements))

Related issue:
- DataDog#253

Releases of the `datadog` lib (it looks to me that there is no risk):
- https://github.com/DataDog/datadogpy/releases
astuyve pushed a commit that referenced this issue Jan 25, 2023
It seems to me that the version is not intentionally locked to the range >= 0.41, < 0.42, and it is more a matter of the fact that poetry treats versions that start with `0` differently when using `^` ([docs](https://python-poetry.org/docs/dependency-specification/#caret-requirements))

Related issue:
- #253

Releases of the `datadog` lib (it looks to me that there is no risk):
- https://github.com/DataDog/datadogpy/releases
@astuyve
Copy link
Contributor

astuyve commented Jan 25, 2023

Sorry for the delay, thanks for the contribution! Will be releasing this shortly after the tests run.

@astuyve astuyve closed this as completed Jan 25, 2023
laminarasm9 added a commit to laminarasm9/datadog-lambda-python that referenced this issue Aug 6, 2024
It seems to me that the version is not intentionally locked to the range >= 0.41, < 0.42, and it is more a matter of the fact that poetry treats versions that start with `0` differently when using `^` ([docs](https://python-poetry.org/docs/dependency-specification/#caret-requirements))

Related issue:
- DataDog/datadog-lambda-python#253

Releases of the `datadog` lib (it looks to me that there is no risk):
- https://github.com/DataDog/datadogpy/releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants