Cut memory overhead.

Author: purple4reina

datadog_lambda/config.py

@@ -13,20 +13,7 @@ def _get_env(key, default=None, cast=None, depends_on_tracing=False):
     @property
     def _getter(self):
         if not hasattr(self, prop_key):
-            if depends_on_tracing and not config.trace_enabled:
-                val = False
-            else:
-                val = os.environ.get(key, default)
-                if cast is not None:
-                    try:
-                        val = cast(val)
-                    except (ValueError, TypeError):
-                        msg = (
-                            "Failed to cast environment variable '%s' with "
-                            "value '%s' to type %s. Using default value '%s'."
-                        )
-                        logger.warning(msg, key, val, cast.__name__, default)
-                        val = default
+            val = self._resolve_env(key, default, cast, depends_on_tracing)
             setattr(self, prop_key, val)
         return getattr(self, prop_key)
 
@@ -44,6 +31,22 @@ def as_list(val):
 
 class Config:
 
+    def _resolve_env(self, key, default=None, cast=None, depends_on_tracing=False):
+        if depends_on_tracing and not self.trace_enabled:
+            return False
+        val = os.environ.get(key, default)
+        if cast is not None:
+            try:
+                val = cast(val)
+            except (ValueError, TypeError):
+                msg = (
+                    "Failed to cast environment variable '%s' with "
+                    "value '%s' to type %s. Using default value '%s'."
+                )
+                logger.warning(msg, key, val, cast.__name__, default)
+                val = default
+        return val
+
     service = _get_env("DD_SERVICE")
     env = _get_env("DD_ENV")
 

tests/test_config.py

@@ -1,6 +1,6 @@
 import pytest
 
-from datadog_lambda.config import config, _get_env
+from datadog_lambda.config import config, _get_env, Config
 
 
 @pytest.fixture
@@ -218,7 +218,7 @@ def test__get_env_does_not_log_when_env_not_set(setenv, monkeypatch):
     setenv("TEST_3", None)
     setenv("TEST_4", None)
 
-    class Testing:
+    class Testing(Config):
         test_1 = _get_env("TEST_1")
         test_2 = _get_env("TEST_2", "purple")
         test_3 = _get_env("TEST_3", "true", bool)