Catch errors when importing profiler. (#695)

* Catch errors when importing profiler.

* Test import of profiler catches error and disables profiling.

* Update linting.

Author: purple4reina

datadog_lambda/wrapper.py

@@ -46,6 +46,8 @@
     extract_http_status_code_tag,
 )
 
+logger = logging.getLogger(__name__)
+
 # ddtrace imports are also tested in
 # dd-trace-py/tests/internal/test_serverless.py please update those tests when
 # making changes to any ddtrace import.
@@ -61,8 +63,12 @@
 
     start()
 
+profiler = None
 if config.profiling_enabled:
-    from ddtrace.profiling import profiler
+    try:
+        from ddtrace.profiling import profiler
+    except Exception as e:
+        logger.error(f"Failed to initialize profiler: [{e.__class__.__name__})] {e}")
 
 if config.llmobs_enabled:
     from ddtrace.llmobs import LLMObs
@@ -75,8 +81,6 @@
     except ImportError:
         from ddtrace.debugging._uploader import LogsIntakeUploaderV1 as SignalUploader
 
-logger = logging.getLogger(__name__)
-
 DD_REQUESTS_SERVICE_NAME = "DD_REQUESTS_SERVICE_NAME"
 DD_SERVICE = "DD_SERVICE"
 
@@ -141,7 +145,7 @@ def __init__(self, func):
             self.response = None
             self.blocking_response = None
 
-            if config.profiling_enabled:
+            if config.profiling_enabled and profiler:
                 self.prof = profiler.Profiler(env=config.env, service=config.service)
 
             if config.trace_extractor:
@@ -283,7 +287,7 @@ def _before(self, event, context):
                     self.blocking_response = get_asm_blocked_response(self.event_source)
             else:
                 set_correlation_ids()
-            if config.profiling_enabled and is_new_sandbox():
+            if config.profiling_enabled and profiler and is_new_sandbox():
                 self.prof.start(stop_on_exit=False, profile_children=True)
             logger.debug("datadog_lambda_wrapper _before() done")
         except Exception as e:

tests/test_wrapper.py

@@ -962,3 +962,13 @@ def lambda_handler(event, context):
         mock_submit.assert_called_once()
         call_args = mock_submit.call_args[0]
         assert call_args[0] is None
+
+
+@patch("datadog_lambda.config.Config.profiling_enabled", True)
+def test_profiling_import_errors_caught(monkeypatch):
+    # when importing profiler fails, disable profiling instead of crashing app
+    monkeypatch.setitem(
+        sys.modules, "ddtrace.profiling", None
+    )  # force ModuleNotFoundError
+    importlib.reload(wrapper)
+    assert not hasattr(wrapper.datadog_lambda_wrapper, "prof")