Skip to content

Fix tags concatenation in custom metric #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

VitoMakarevich
Copy link
Contributor

@VitoMakarevich VitoMakarevich commented Mar 31, 2022

What does this PR do?

Fix concatenated tags for custom metrics.

Motivation

A bug that prevents from submitting more than 1 tag.
Bugfix for #75

Testing Guidelines

Unit test and test on a real AWS environment with the custom-built jar.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@VitoMakarevich VitoMakarevich requested a review from a team as a code owner March 31, 2022 07:52
@VitoMakarevich
Copy link
Contributor Author

@IvanTopolcic please take a look

Copy link
Contributor

@IvanTopolcic IvanTopolcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks so much for the fix and report, we really appreciate it! I'll go ahead and release a new version of the Java library and I'll close the issue once that's done.

@IvanTopolcic IvanTopolcic merged commit 97837c7 into DataDog:main Mar 31, 2022
@VitoMakarevich
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants