Deprecate old HTTP wrapping methods and add instructions for installing dd-trace-java. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocs
changed the title
nhinsch
reviewed
Feb 23, 2021
README.md
Outdated
| Don't see your favorite client? Open an issue and request it. Datadog is adding to | ||
| this library all the time. | ||
| The Java Tracer adds a nontrivial cold start penalty. | ||
| Expect roughly 6 seconds per cold start if your lambda function is configured with 3008MB of memory. |
nhinsch
reviewed
Feb 23, 2021
README.md
Outdated
|
|
||
| ### HttpUrlConnection examples | ||
| ### Compatable Java runtimes |
nhinsch
reviewed
Feb 23, 2021
README.md
Outdated
| by cloning the existing Lambda Pipeline. The new parser can extract the trace context from the correct position in the logs. | ||
| Use the helper `_trace_context` to extract the trace context. For example, if your log line looked like: | ||
| The dd-trace-java tracer will automatically add trace context to outgoing requests for a number of popular services. | ||
| The list of instrument services can be found here: https://docs.datadoghq.com/tracing/setup_overview/compatibility_requirements/java/ . |
There was a problem hiding this comment.
instrument -> instrumented
nhinsch
reviewed
Feb 23, 2021
| to any log message. | ||
| ``` | ||
| java_tracer %{date("yyyy-MM-dd HH:mm:ss"):timestamp}\s\<%{uuid:lambda.request_id}\>\s%{word:level}\s+%{data:call_site}%{_trace_context}%{data:message} | ||
| ``` |
There was a problem hiding this comment.
Is this parser the same one we provide out of the box with the default Lambda log pipeline? If that is the case, shouldn't this just work without the customer having to know about the parser? If that is not the case, is there a reason we can't format the logs in the format already understood by the default parser?
There was a problem hiding this comment.
We don't have the power (as far as I know) to change how the customer formats their logs. We can just suggest formats. I think the smart thing to do is to bias towards action, get this out there, and see how customers use it.
nhinsch
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds installation instructions for the Java tracer. Marks some functions deprecated that the tracer does better.
Motivation
Testing Guidelines
Additional Notes
Types of changes
Checklist