Skip to content

[POC][RUM-9952] send event on vital start #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[POC][RUM-9952] send event on vital start #3570

wants to merge 3 commits into from

Conversation

cy-moi
Copy link
Collaborator

@cy-moi cy-moi commented May 26, 2025 •
edited
Loading

No description provided.

cy-moi added 2 commits May 14, 2025 18:08
@cy-moi
Emit event when startDurationVital is called
1307003 
- For testing purposes of User Story Monitoring, we want to try send
an event whenever the api is called with a status. Backend will later
aggregate base on the events sent.
@cy-moi
Only send events when user story option is set
00e6022
@cy-moi
Copy link
Collaborator Author

cy-moi commented May 26, 2025

/to-staging -@ tomorrow at 8am CEST

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 26, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-26 14:32:44 UTC ℹ️ Start processing command /to-staging -@ tomorrow at 8am CEST

2025-05-26 14:32:52 UTC ℹ️ Branch Integration: scheduled for Tue, 27 May 2025 06:00:00 UTC

This integration request is scheduled for Tue, 27 May 2025 06:00:00 UTC

2025-05-27 06:12:03 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 00e6022ed4 has been merged into staging-22 in merge commit 5a0698c87d.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-22

dd-mergequeue bot added a commit that referenced this pull request May 27, 2025
@dd-mergequeue @cy-moi
Integrate congyao/RUM-9952-send-event-on-vital-start (#3570) into sta…
5a0698c 
…ging-22

Integrated commit sha: 00e6022

Co-authored-by: cy-moi <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (3c18298) to head (05ae1ef).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...kages/rum-core/src/domain/vital/vitalCollection.ts 40.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   92.22%   92.16%   -0.07%     
==========================================
  Files         313      313              
  Lines        8041     8050       +9     
  Branches     1815     1818       +3     
==========================================
+ Hits         7416     7419       +3     
- Misses        625      631       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cy-moi cy-moi force-pushed the congyao/RUM-9952-send-event-on-vital-start branch from 39dfe51 to 9b8c5f8 Compare May 28, 2025 08:18
@cy-moi cy-moi force-pushed the congyao/RUM-9952-send-event-on-vital-start branch from 9b8c5f8 to 05ae1ef Compare May 28, 2025 08:26
@cy-moi
Copy link
Collaborator Author

cy-moi commented May 28, 2025

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-28 09:40:19 UTC ℹ️ Start processing command /to-staging

2025-05-28 09:40:27 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 20m43s (p90)

Commit 05ae1efae5 will soon be integrated into staging-22.

2025-05-28 10:05:14 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 05ae1efae5 has been merged into staging-22 in merge commit a3305269e4.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-22

dd-mergequeue bot added a commit that referenced this pull request May 28, 2025
@dd-mergequeue @cy-moi
Integrate congyao/RUM-9952-send-event-on-vital-start (#3570) into sta…
a330526 
…ging-22

Integrated commit sha: 05ae1ef

Co-authored-by: cy-moi <[email protected]>
@cy-moi
Copy link
Collaborator Author

cy-moi commented Jun 2, 2025

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 2, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-02 07:46:20 UTC ℹ️ Start processing command /to-staging

2025-06-02 07:46:27 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 0s (p90)

Commit 05ae1efae5 will soon be integrated into staging-23.

2025-06-02 08:02:18 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 05ae1efae5 has been merged into staging-23 in merge commit 8058974b93.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-23

dd-mergequeue bot added a commit that referenced this pull request Jun 2, 2025
@dd-mergequeue @cy-moi
Integrate congyao/RUM-9952-send-event-on-vital-start (#3570) into sta…
8058974 
…ging-23

Integrated commit sha: 05ae1ef

Co-authored-by: cy-moi <[email protected]>
@dd-devflow dd-devflow bot added the staging-23 label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
staging-22 staging-23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cy-moi @codecov-commenter