✨ [RUMF-1580] Implement storage fallback #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_fallback
branch
from
f35a90f to
5f16faa
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_Local_Storage
branch
from
70842b8 to
4910506
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_fallback
branch
from
5f16faa to
73df497
Compare
yannickadam
changed the title
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_Local_Storage
branch
from
4910506 to
205349f
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_fallback
branch
from
73df497 to
b26c828
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
+ Coverage 93.93% 94.25% +0.31%
==========================================
Files 204 205 +1
Lines 6122 6142 +20
Branches 1354 1358 +4
==========================================
+ Hits 5751 5789 +38
+ Misses 371 353 -18 ☔ View full report in Codecov by Sentry. |
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_Local_Storage
branch
from
205349f to
90064ab
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_fallback
branch
from
b26c828 to
3c9ac7f
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_Local_Storage
branch
from
90064ab to
3e1c1e3
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_fallback
branch
2 times, most recently
from
d408034 to
305deaf
Compare
yannickadam
force-pushed
the
yannick.adam/RUMF-1580_Implement_fallback
branch
from
f7661fb to
83acc68
Compare
yannickadam
commented
Jun 7, 2023
bcaudan
reviewed
Jun 7, 2023
packages/core/src/domain/session/storeStrategies/sessionInLocalStorage.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Jun 7, 2023
bcaudan
reviewed
Jun 12, 2023
packages/core/src/domain/session/storeStrategies/sessionInLocalStorage.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Jun 12, 2023
Comment on lines
+24
to
+28
| /** | ||
| * Every second, the storage will be polled to check for any change that can occur | ||
| * to the session state in another browser tab, or another window. | ||
| * This value has been determined from our previous cookie-only implementation. | ||
| */ |
Base automatically changed from
yannick.adam/RUMF-1580_Implement_Local_Storage
to
main
June 14, 2023 05:23
amortemousque
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When cookies are not available, allows the sessionManager to fallback to localStorage.
Changes
Testing
I have gone over the contributing documentation.