feat: add a total file size summary to the summary statistics line for the anvil explorer (#4495) #4571
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds total file size information to the summary statistics display in the anvil explorer, enhancing how data summaries are presented to users. The changes introduce a new summary type for displaying total file size and improve the formatting consistency across all summary statistics.
- Added a new
TOTAL_FILE_SIZEsummary type to the existing summary enumeration and related mappings - Updated the summary response binding to format all counts consistently using appropriate formatters
- Modified the site-specific configuration to include the new total file size in the summary display order
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| site-config/anvil-cmg/dev/index/common/constants.ts | Added TOTAL_FILE_SIZE to the destructured constants and summary display order |
| app/components/Index/common/indexTransformer.ts | Removed redundant formatting logic since formatting is now handled in the binder functions |
| app/components/Index/common/entities.ts | Added TOTAL_FILE_SIZE enum value to the SUMMARY enumeration |
| app/components/Index/common/constants.ts | Added formatting imports, updated BIND_SUMMARY_RESPONSE with proper typing and formatting, and added mappings for the new summary type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ): [string, string][] { | ||
| return summaries.map((summary) => { | ||
| const summaryBinderFn = BIND_SUMMARY_RESPONSE[summary]; | ||
| const count = formatCountSize(summaryBinderFn(summaryResponse)); |
There was a problem hiding this comment.
formatCountSize removed and added to each summaryBinderFn so that formatFileSize able to used for totalFileSize formatting.
| [key in SUMMARY]: (r: AzulSummaryResponse) => string; | ||
| } = { | ||
| [BIOSAMPLES]: (r: AzulSummaryResponse): string => | ||
| formatCountSize(getSummaryCount(r, SUMMARY_KEY.BIOSAMPLES)), |
There was a problem hiding this comment.
formatCountSize added to each binder fn to allow totalFileSize to be formatted by formatFileSize. See https://github.com/DataBiosphere/data-browser/pull/4571/files#r2408973202.
…r the anvil explorer (#4495)
frano-m
force-pushed
the
fran/4495-anvil-summary
branch
from
11c285a to
4b89157
Compare
2 participants
Closes #4495.
This pull request enhances how summary data is displayed by introducing support for showing total file size and improving the formatting of summary counts. The main changes include adding a new summary type for total file size, updating how summary counts are formatted for display, and ensuring these changes are reflected in both shared and site-specific configuration files.
Summary display improvements:
TOTAL_FILE_SIZEto theSUMMARYenum and included it in summary key and label mappings, allowing the UI to display total file size information. [1] [2] [3]BIND_SUMMARY_RESPONSEmapping inconstants.tsto useformatCountSizefor all count values andformatFileSizespecifically for total file size, ensuring consistent and user-friendly formatting of summary data.site-config/anvil-cmg/dev/index/common/constants.ts) to include the new total file size summary.Codebase consistency and cleanup:
mapSummaryfunction, since formatting is now handled by the binder functions inBIND_SUMMARY_RESPONSE. [1] [2]formatCountSize,formatFileSize) inconstants.tsto support the new summary formatting logic.