Fix Clang model bug, improve SSE intrinsics code and add tests for q_math transform functions #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've kept some of them which are unused but are needed to have a complete API, such as TransInsTranslation. Removed ones are either about multiplying by an inverse, or specify a rotation in radians (which is at odds with the codebase that uses degrees 99% of the time).
And fix a bug in one implementation of TransInsScale (this function is not used in the codebase). These transform_t functions deal with composing rotation, translation, and scale operations. So transform_t represents a similarity-preserving transformation. All of the q_math transform functions get a test, except the 3 that have to do with interpolation (I'm not sure how that is supposed to work).
In 2 cases we were forming a vector from (a.xyz, b.w) but it turns out the "junk" w component of a already contained the desired b.w value, so we can just use a is-is.
Fixes the Clang part of DaemonEngine#1312. The problem is that LLVM wrongly considers __m128 to have floating-point semantics at all times. When it sees an all-ones mask in some component it wrongly sees it as a NaN and replaces it with an undefined value when in -ffinite-math mode. In the cases where the new first_XYZ_second_W is used, that is actually what Clang itself outputs after optimizing the original intrinsics code (with a non-bugged flag configuration). So hopefully it is faster anyway.
|
I confirm it fixes the bugs with Clang 19 from: But it doesn't fix the bugs with GCC 14. |
|
I confirm that I get no bug when combining:
|
DolceTriade
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.