Skip to content

Commit dd5a11c

Browse files
committed
fix Build error when using dependency injection but not configuration libraries #202
1 parent 671bf68 commit dd5a11c

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

sandbox/GeneratorSandbox/GeneratorSandbox.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,15 @@
1616
</PropertyGroup>
1717

1818
<ItemGroup>
19+
1920
<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.6" />
21+
<!--
22+
<PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.6" />
23+
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.6" />
2024
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.9.0" />
2125
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.9.0" />
2226
<PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.9.0" />
23-
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.9.0" />
27+
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.9.0" />-->
2428
</ItemGroup>
2529

2630
<ItemGroup>

sandbox/GeneratorSandbox/Program.cs

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
using ConsoleAppFramework;
2-
using Google.Protobuf.Reflection;
32
using Microsoft.Extensions.DependencyInjection;
4-
using Microsoft.Extensions.Logging;
53
using System.Diagnostics.CodeAnalysis;
64
using System.Runtime.CompilerServices;
75

@@ -20,20 +18,24 @@
2018
return new GlobalOptions(dryRun, verbose, intParameter);
2119
});
2220

23-
app.ConfigureServices((context, configuration, services) =>
21+
app.ConfigureServices((context, _, services) =>
2422
{
2523
// store global-options to DI
2624
var globalOptions = (GlobalOptions)context.GlobalOptions;
2725
services.AddSingleton(globalOptions);
2826

2927
// check global-options value to configure services
30-
services.AddLogging(logging =>
31-
{
32-
if (globalOptions.Verbose)
33-
{
34-
logging.SetMinimumLevel(LogLevel.Trace);
35-
}
36-
});
28+
//services.AddLogging(logging =>
29+
//{
30+
// if (globalOptions.Verbose)
31+
// {
32+
// logging.SetMinimumLevel(LogLevel.Trace);
33+
// }
34+
//});
35+
});
36+
37+
app.ConfigureLogging((context, _, services) =>
38+
{
3739
});
3840

3941
app.Add<Commands>();

src/ConsoleAppFramework/Emitter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ public void EmitConfigure(SourceBuilder sb, DllReference dllReference)
810810
sb.AppendLine();
811811
using (sb.BeginBlock("public ConsoleApp.ConsoleAppBuilder ConfigureServices(Action<IServiceCollection> configure)"))
812812
{
813-
sb.AppendLine("this.configureServices = (_, _, services) => configure(services);");
813+
sb.AppendLine("this.configureServices = (_, services) => configure(services);");
814814
sb.AppendLine("return this;");
815815
}
816816

0 commit comments

Comments
 (0)