Skip to content

Linter pr 1: testifylint #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Linter pr 1: testifylint #587

merged 10 commits into from
Jan 27, 2025

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 22, 2024

This PR lints using testifylint.

There will be other PR's based on it.

@webmaster128 please try to figure out what to do with mockinfobin. I really don't know. You should be able to push to my branch, if not, feel free to just make another PR.

@faddat
Copy link
Contributor Author

faddat commented Dec 22, 2024

=== RUN   TestGetMetrics
    lib_test.go:440: 
                Error Trace:    /Users/faddat/swappable-vm/internal/api/lib_test.go:440
                Error:          Not equal: 
                                expected: 0x0
                                actual  : 0x1
                Test:           TestGetMetrics

is the only remaining issue. I think I hit this when refactoring to use wazero also.

@faddat faddat changed the title testifylint execpt for the MockInfoBin testifylint Dec 22, 2024
@faddat faddat mentioned this pull request Dec 23, 2024
This was referenced Jan 12, 2025
@faddat faddat changed the title testifylint Linter pr 1: testifylint Jan 17, 2025
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor adjustments and think this is good to merge now

@chipshort chipshort merged commit 50c6e4a into CosmWasm:main Jan 27, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants