Update facet configuration position and optionsLimit parameters
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocca102
force-pushed
the
ci-4556-java-update-options_limit-and-position-types-to-integer
branch
from
b8d0f96 to
d3d4b1f
Compare
stanlp1
reviewed
Jun 18, 2025
| @@ -177,12 +177,12 @@ public void testCreateFacetOptionConfigurations() throws Exception { | |||
| assertEquals("test-option", jsonOption1.get("value")); | |||
| assertEquals("test-alias", jsonOption1.get("value_alias")); | |||
| assertEquals("Test Option", jsonOption1.get("display_name")); | |||
| assertEquals(1, jsonOption1.get("position")); | |||
| assertEquals(Integer.valueOf(1), jsonOption1.get("position")); | |||
There was a problem hiding this comment.
Can we add a similar test to this where we set values to null, see if it gets set correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
positionandoptions_limitdefault to zero due to typeintFix
inttoIntegerwhich will default the values to null instead of zero