Fix House Meeting Attendance Status Display #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably works. But it's currently untested
audiolion
reviewed
Aug 28, 2017
conditional/util/member.py
Outdated
| @@ -137,4 +137,6 @@ def get_hm(member): | |||
| HouseMeeting.date).filter( | |||
| HouseMeeting.date > start_of_year(), | |||
| MemberHouseMeetingAttendance.uid == member.uid) | |||
| if only_absent: | |||
| h_meetings = [hm for hm in h_meetings if hm.attendance_status == "Absent"] | |||
There was a problem hiding this comment.
Are SQLAlchemy queries lazily loaded? If so h_meetings should produce a SQLAlchemy Query object but not actually hit the database until it is used. IF that is the case
if only_absent:
h_meetings = h_meetings.filter(MemberHouseMeetingAttendance.attendance_status == "Absent")will work nicely and not require evaluating the entire queryset and filtering it in memory
There was a problem hiding this comment.
Yup it does. Good catch, thanks.
|
Once this passes CI, I am fine to 🚢 it. |
mbillow
changed the title
mbillow
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably works. But it's currently untested