Skip to content

Test suite broken on Windows CMD #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ColMelvin opened this issue Apr 2, 2018 · 1 comment
Closed

Test suite broken on Windows CMD #39

ColMelvin opened this issue Apr 2, 2018 · 1 comment
Assignees
Labels

Comments

@ColMelvin
Copy link
Owner

When running prove in the Windows cmd.exe command prompt, the test suite fails to populate the Git repo, failing with the following error on git svn fetch - for each and every test:

Bad URL passed to RA layer: Illegal repository URL 'file://<windows_path>' at /usr/share/perl5/vendor_perl/Git/SVN.pm line 148.

Additionally, the test suite fails to even load bin/git-svn-diff, as the file type is not recognized by Windows, and therefore Perl is not used to invoke it. Together, these issues make it impossible to test git-svn-diff on native Windows. And that makes it difficult to say, assuredly, whether or not git-svn-diff supports native Windows (though, if the tests are any indication, it probably doesn't).

That said, Window users can use Git for Windows with the supplied git-bash executable. The tests both run and pass in that environment.

@ColMelvin ColMelvin added the bug label Apr 2, 2018
@ColMelvin ColMelvin self-assigned this Apr 2, 2018
ColMelvin added a commit that referenced this issue Apr 2, 2018
Modify the testing infrastructure to better work with Git for Windows on
native Windows.  Due to limitations/bugs in the current implementation
of Git.pm, git-svn-diff will not run in this environment.  However, once
those issues are addressed upstream, these changes will make it possible
to validate git-svn-diff.

When it all comes together, users will be able to run git-svn-diff in a
native Windows environment (assuming they have Perl installed somewhere,
with a modern Git.pm).  Batch or PowerShell scripts will be possible;
users can completely avoid Git Bash, if they so desire.

Issue: #39
@ColMelvin
Copy link
Owner Author

While the commit fixes testing, the script itself is still failing because of upstream bugs. Once git-for-windows/git#1602 & git-for-windows/git#1603 are fixed, testing on native Windows can begin in earnest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant